From be64738c8ba623f56a7c2220147f59e6d0b15825 Mon Sep 17 00:00:00 2001 From: Hossy Date: Wed, 20 Jul 2022 15:58:27 -0500 Subject: [PATCH 1/2] Fix default Syno port to match documentation that says it defaults to 5001 when scheme is https --- deploy/synology_dsm.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/synology_dsm.sh b/deploy/synology_dsm.sh index f30f82c0..c20ae486 100644 --- a/deploy/synology_dsm.sh +++ b/deploy/synology_dsm.sh @@ -58,7 +58,7 @@ synology_dsm_deploy() { # defaulting to localhost and http because it's localhost... [ -n "${SYNO_Scheme}" ] || SYNO_Scheme="http" [ -n "${SYNO_Hostname}" ] || SYNO_Hostname="localhost" - [ -n "${SYNO_Port}" ] || SYNO_Port="5000" + [ -n "${SYNO_Port}" ] || SYNO_Port=$( [ $(echo $SYNO_Scheme | tr '[:upper:]' '[:lower:]') = "https" ] && echo '5001' || echo '5000' ) _savedeployconf SYNO_Scheme "$SYNO_Scheme" _savedeployconf SYNO_Hostname "$SYNO_Hostname" From 3a396abc177e715be5819f7b1aed8f14c0f584ec Mon Sep 17 00:00:00 2001 From: Hossy Date: Thu, 21 Jul 2022 15:03:25 -0500 Subject: [PATCH 2/2] fix quoting -- SC2046: Quote this to prevent word splitting. --- deploy/synology_dsm.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/synology_dsm.sh b/deploy/synology_dsm.sh index c20ae486..0f2f6ea1 100644 --- a/deploy/synology_dsm.sh +++ b/deploy/synology_dsm.sh @@ -58,7 +58,7 @@ synology_dsm_deploy() { # defaulting to localhost and http because it's localhost... [ -n "${SYNO_Scheme}" ] || SYNO_Scheme="http" [ -n "${SYNO_Hostname}" ] || SYNO_Hostname="localhost" - [ -n "${SYNO_Port}" ] || SYNO_Port=$( [ $(echo $SYNO_Scheme | tr '[:upper:]' '[:lower:]') = "https" ] && echo '5001' || echo '5000' ) + [ -n "${SYNO_Port}" ] || SYNO_Port=$( [ "$(echo $SYNO_Scheme | tr '[:upper:]' '[:lower:]')" = "https" ] && echo '5001' || echo '5000' ) _savedeployconf SYNO_Scheme "$SYNO_Scheme" _savedeployconf SYNO_Hostname "$SYNO_Hostname"